Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-suggestion-item): add new component #1336

Merged
merged 4 commits into from
Mar 24, 2020
Merged

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Mar 23, 2020

An abstract item to serve as a suggestion item within the Input. Based on the suggestion item properties, the Input will display either a StandardListItem, or a GroupHeaderListItem within the suggestion popover.

FIXES: #1313

The usage becomes:

<ui5-input id="myInput2" show-suggestions >
        <ui5-suggestion-item group text="group 1"></ui5-suggestion-item>
	<ui5-suggestion-item text="Cozy"></ui5-suggestion-item>
	<ui5-suggestion-item text="Compact"></ui5-suggestion-item>
	<ui5-suggestion-item text="Condensed"></ui5-suggestion-item>
</ui5-input>

Although this is still compatible:

<ui5-input  show-suggestions >
	<ui5-li>Cozy</ui5-li>
	<ui5-li>Compact</ui5-li>
	<ui5-li>Condensed</ui5-li>
</ui5-input>

Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works, tested on IE as well.

kitchen-scripts.js has not been modified to use the new item, but it's good to have one place to check for compatibility so let's keep it IMO

@ilhan007 ilhan007 merged commit 786f4e9 into master Mar 24, 2020
@ilhan007 ilhan007 deleted the feat-suggestion-item branch March 24, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui5-input suggestions do not properly support GroupHeaderListItem
2 participants