feat(ui5-mcb-item): initial implementation #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: ui5-multi-combobox no longer accepts ui5-li for items use ui5-multi-combobox-item instead.
vladitasev
reviewed
Feb 27, 2020
| import ComboBoxItem from "./ComboBoxItem.js"; | ||
|
|
||
| class MultiComboBoxItem extends ComboBoxItem { | ||
| static get metadata() { |
There was a problem hiding this comment.
Will the doc plugin be able to parse this correctly when you add help?
| class MultiComboBoxItem extends ComboBoxItem { | ||
| static get metadata() { | ||
| return { | ||
| tag: "ui5-multi-combobox-item", |
- docs are added to item classes BREAKING CHANGE: Change the tag name from ui5-combobox-item to ui5-cb-item
MapTo0
changed the title
ilhan007
previously requested changes
Feb 28, 2020
|
|
||
| /** | ||
| * @class | ||
| * The <code>ui5-cb-item</code> represents the item for a <code>ui5-combobox</code>. |
ilhan007
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: ui5-multi-combobox no longer accepts ui5-li for items. Use ui5-mcb-item instead.