Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-li): correct focus color when active #1143

Merged
merged 2 commits into from
Jan 16, 2020
Merged

fix(ui5-li): correct focus color when active #1143

merged 2 commits into from
Jan 16, 2020

Conversation

ilhan007
Copy link
Member

When pressed down the list item focus color should be changed to fulfil the constrast ratio with the background in active state.

@ilhan007 ilhan007 requested a review from MapTo0 January 16, 2020 12:14
@ilhan007 ilhan007 requested a review from nnaydenow January 16, 2020 13:22
@ilhan007 ilhan007 merged commit 7c4ee77 into master Jan 16, 2020
@ilhan007 ilhan007 deleted the fix-listitem-avtive-focus branch January 16, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifoosid fifoosid fifoosid approved these changes

@MapTo0 MapTo0 Awaiting requested review from MapTo0

@nnaydenow nnaydenow Awaiting requested review from nnaydenow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilhan007 @fifoosid