Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ui5-combobox initial implementation #1123

Merged
merged 8 commits into from
Jan 13, 2020
Merged

feat: ui5-combobox initial implementation #1123

merged 8 commits into from
Jan 13, 2020

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Jan 7, 2020

No description provided.

@MapTo0 MapTo0 requested review from fifoosid and ilhan007 January 10, 2020 12:57
vladitasev
vladitasev approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The item doesn't need a define funciton and the css file is empty, but leave it like that for the moment

@MapTo0 MapTo0 merged commit ca2fa23 into master Jan 13, 2020
@MapTo0 MapTo0 deleted the combobox branch January 13, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@fifoosid fifoosid Awaiting requested review from fifoosid

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MapTo0 @vladitasev