From e8997089e3fecb27a22ba8f656d67cfa275ad5f4 Mon Sep 17 00:00:00 2001
From: Vladislav Tasev <vladitasev@users.noreply.github.com>
Date: Wed, 12 Feb 2020 16:25:18 +0200
Subject: [PATCH] fix(ui5-dialog): dialog focus trapping works again (#1213)

---
 packages/main/src/Dialog.hbs | 2 +-
 packages/main/src/Popup.js   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/main/src/Dialog.hbs b/packages/main/src/Dialog.hbs
index 7a45de2895ac..8a16e6d23eeb 100644
--- a/packages/main/src/Dialog.hbs
+++ b/packages/main/src/Dialog.hbs
@@ -1,6 +1,6 @@
 {{>include "./Popup.hbs"}}
 
-<span class="ui5-popup-frame">
+<span class="ui5-popup-frame" @focusin="{{_onfocusin}}">
 	<span id="{{_id}}-firstfe" tabindex="0"></span>
 	<div style="{{zindex}}" class="ui5-dialog-root-parent {{classes.dialogParent}}">
 		<div tabindex="-1" aria-labelledby="{{headerId}}" role="dialog" aria-modal="true" class="ui5-popup-root ui5-dialog-root">
diff --git a/packages/main/src/Popup.js b/packages/main/src/Popup.js
index 9d8c2f483677..9f8ec8fd3010 100644
--- a/packages/main/src/Popup.js
+++ b/packages/main/src/Popup.js
@@ -385,7 +385,7 @@ class Popup extends UI5Element {
 		}
 	}
 
-	onfocusin(event) {
+	_onfocusin(event) {
 		this.preserveFocus(event, this.getPopupDomRef());
 	}