From c559ac0bb54c40152cd7c0bd435d84affaf109b9 Mon Sep 17 00:00:00 2001 From: Martin Date: Thu, 23 May 2019 16:00:26 +0300 Subject: [PATCH] fix(ui5-multi-combobox): docs and API improvements (#438) - suggestion module is no longer needed to run the component - documentation with keyboard handling is updated - sample page responsiveness is improved --- packages/main/src/MultiComboBox.hbs | 1 - packages/main/src/MultiComboBox.js | 14 ++++++++++++++ .../main/samples/MultiComboBox.sample.html | 14 ++++++++------ 3 files changed, 22 insertions(+), 7 deletions(-) diff --git a/packages/main/src/MultiComboBox.hbs b/packages/main/src/MultiComboBox.hbs index b47c16861706..4440ecc46ac4 100644 --- a/packages/main/src/MultiComboBox.hbs +++ b/packages/main/src/MultiComboBox.hbs @@ -5,7 +5,6 @@ ?disabled={{ctr.disabled}} ?readonly={{ctr.readonly}} value-state="{{ctr.valueState}}" - show-suggestions @ui5-input="{{ctr._inputLiveChange}}" @ui5-change={{ctr._inputChange}} @keydown="{{ctr._keydown}}"> diff --git a/packages/main/src/MultiComboBox.js b/packages/main/src/MultiComboBox.js index 65a8e9431d2e..72e2f8a538b6 100644 --- a/packages/main/src/MultiComboBox.js +++ b/packages/main/src/MultiComboBox.js @@ -192,6 +192,18 @@ const metadata = { *
  • Drop-down arrow - expands\collapses the option list.
    • *
  • Option list - the list of available options.
    • * + *

    Keyboard handling

    + * + *

    Tokens

    + * + * + *

    Picker

    + * Alt + arrow down or F4 - opens the picker. + * * * @constructor * @author SAP SE @@ -327,10 +339,12 @@ class MultiComboBox extends UI5Element { _handleKeyDown(event) { if (isShow(event) && !this.readonly && !this.disabled) { + event.preventDefault(); this._togglePopover(); } if (isDown(event) && this._getPopover()._isOpen && this.items.length) { + event.preventDefault(); const list = this.shadowRoot.querySelector(".ui5-multi-combobox-all-items-list"); list._itemNavigation.current = 0; list.items[0].focus(); diff --git a/packages/main/test/sap/ui/webcomponents/main/samples/MultiComboBox.sample.html b/packages/main/test/sap/ui/webcomponents/main/samples/MultiComboBox.sample.html index 8a65574dd450..733dd82e6c35 100644 --- a/packages/main/test/sap/ui/webcomponents/main/samples/MultiComboBox.sample.html +++ b/packages/main/test/sap/ui/webcomponents/main/samples/MultiComboBox.sample.html @@ -3,7 +3,8 @@ <ui5-multi-combobox> - + @@ -31,7 +32,8 @@