Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload building of Fiori element-based apps produce verbose log content #431

Closed
1 of 6 tasks
petermuessig opened this issue Jan 24, 2020 · 7 comments · Fixed by SAP/ui5-builder#479
Closed
1 of 6 tasks
Labels
module/ui5-builder Related to the UI5 Builder module

Comments

@petermuessig
Copy link

Expected Behavior

Build is successful without error logging.

Current Behavior

Build is logging a verbose error when analyzing the dependencies of apps using modules from Smart Templates / Fiori elements.

Steps to reproduce the issue

  1. Create a Fiori elements based app in SAP Web IDE
  2. Run the build in SAP Web IDE or the ui5 build directly

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): latest
  • Node.js Version: independent
  • npm Version: independent
  • OS/Platform: independent

Affected components (if known)

Log Output / Stack Trace

Running task generateComponentPreload...
ERR! lbt:analyzer:SmartTemplateAnalyzer Error: resource not found in pool: 'sap/suite/ui/generic/template/ListReport/Component.js'
ERR! lbt:analyzer:SmartTemplateAnalyzer     at LocatorResourcePool.findResource (/tmp/webide.668.build/proj/node_modules/@ui5/cli/node_modules/@ui5/builder/lib/lbt/resources/ResourcePool.js:177:10)
@codeworrior
Copy link
Member

Looks like the app is missing a mandatory dependency.

@petermuessig
Copy link
Author

Yes, a dependency from the UI5 distribution layer which we need to publish. I just want to document this here to have a reference for customer tickets.

@ShashankPincha
Copy link

Facing the same issue, unfortunately raised a ticket in @ui5/cli before I saw this ticket. https://github.com/SAP/ui5-cli/issues/294

Is there any solution?

@petermuessig
Copy link
Author

Hi @ShashankPincha , it is not a critical issue, just a logging that the SmartTemplate (Fiori elements) stuff is missing as a dependency and thus the builder logs this as missing modules. We are working right now to release the SAPUI5 dependencies on npmjs.com which will happen hopefully soon. The solution is in the pipeline... :-)

@ShashankPincha
Copy link

Hi @petermuessig.
Yup, I deployed to ABAP Repo and opened the app in the FLP and it all worked fine, I got the bellow error after deployment (not 100% sure if it's related) so I thought it maybe a critical issue.

image

Thank you.

@RandomByte
Copy link
Member

The missing SAPUI5 dependency "sap.suite.ui.generic.template" is now available for install through the UI5 Tooling. See https://sap.github.io/ui5-tooling/pages/SAPUI5/ and https://blogs.sap.com/2020/04/01/ui5ers-buzz-49-the-ui5-tooling-and-sapui5-the-next-step/ for details

@RandomByte
Copy link
Member

Reopening this issue based on new input. The error message reported here is not expected when generating a Component Preload.

@codeworrior and I already figured out a potential solution, PR will follow

@RandomByte RandomByte reopened this Jul 15, 2020
RandomByte referenced this issue in SAP/ui5-builder Jul 16, 2020
…is expected

In some cases it can be expected that SmartTemplateAnalyzer does not
have access to second-degree dependencies. In such cases, no error
should be thrown. Currently this causes misleading error logs, for
example in case of component preload generation for a Fiori Elements
project where no framework dependencies are available.

Resolves https://github.com/SAP/ui5-builder/issues/404
RandomByte referenced this issue in SAP/ui5-builder Jul 21, 2020
…is expected (#479)

In some cases it can be expected that SmartTemplateAnalyzer does not
have access to second-degree dependencies. In such cases, no error
should be thrown. Currently this causes misleading error logs, for
example in case of component preload generation for a Fiori Elements
project where no framework dependencies are available.

Resolves https://github.com/SAP/ui5-builder/issues/404
@RandomByte RandomByte transferred this issue from SAP/ui5-builder Nov 20, 2020
@RandomByte RandomByte added the module/ui5-builder Related to the UI5 Builder module label Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/ui5-builder Related to the UI5 Builder module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants