-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload building of Fiori element-based apps produce verbose log content #431
Comments
Looks like the app is missing a mandatory dependency. |
Yes, a dependency from the UI5 distribution layer which we need to publish. I just want to document this here to have a reference for customer tickets. |
Facing the same issue, unfortunately raised a ticket in @ui5/cli before I saw this ticket. https://github.com/SAP/ui5-cli/issues/294 Is there any solution? |
Hi @ShashankPincha , it is not a critical issue, just a logging that the SmartTemplate (Fiori elements) stuff is missing as a dependency and thus the builder logs this as missing modules. We are working right now to release the SAPUI5 dependencies on npmjs.com which will happen hopefully soon. The solution is in the pipeline... :-) |
Hi @petermuessig. Thank you. |
The missing SAPUI5 dependency "sap.suite.ui.generic.template" is now available for install through the UI5 Tooling. See https://sap.github.io/ui5-tooling/pages/SAPUI5/ and https://blogs.sap.com/2020/04/01/ui5ers-buzz-49-the-ui5-tooling-and-sapui5-the-next-step/ for details |
Reopening this issue based on new input. The error message reported here is not expected when generating a Component Preload. @codeworrior and I already figured out a potential solution, PR will follow |
…is expected In some cases it can be expected that SmartTemplateAnalyzer does not have access to second-degree dependencies. In such cases, no error should be thrown. Currently this causes misleading error logs, for example in case of component preload generation for a Fiori Elements project where no framework dependencies are available. Resolves https://github.com/SAP/ui5-builder/issues/404
…is expected (#479) In some cases it can be expected that SmartTemplateAnalyzer does not have access to second-degree dependencies. In such cases, no error should be thrown. Currently this causes misleading error logs, for example in case of component preload generation for a Fiori Elements project where no framework dependencies are available. Resolves https://github.com/SAP/ui5-builder/issues/404
Expected Behavior
Build is successful without error logging.
Current Behavior
Build is logging a verbose error when analyzing the dependencies of apps using modules from Smart Templates / Fiori elements.
Steps to reproduce the issue
Context
ui5 --version
when using the CLI):latest
independent
independent
independent
Affected components (if known)
Log Output / Stack Trace
The text was updated successfully, but these errors were encountered: