-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] minify task: Use workerpool for terser #875
Conversation
54353f2
to
ca3190e
Compare
3ffea21
to
fd5c77f
Compare
fd5c77f
to
ea9df9b
Compare
Based on #700 * Changed logging to verbose * Added option 'useWorkers' to processor. Implicit activation through taskUtil parameter seemed a bit odd. Moved that to the minify task * Added JSDoc
ea9df9b
to
75463c3
Compare
I did some benchmarks according to our documentation, comparing this PR to the current main branch: openui5-sample-app
sap.ui.core
OpenUI5 testsuite (including dependencies)
Specs: MacBook Pro M1 Max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
If myFun()
in the test fixtures was meant to be myFunc()
, you might want to fix that. But the tests still make sense in their current state. A reader just may wonder about the name mismatch.
ea298bb
to
28efc4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Based on #700:
taskUtil parameter seemed a bit odd. Moved that to the minify task