[FEATURE] ApplicationFormatter: Implement manifest.appdescr_variant fallback #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
changed the title
RandomByte
force-pushed
the
app-variant-namespace-fallback
branch
from
62a05b1 to
838af70
Compare
RandomByte
force-pushed
the
app-variant-namespace-fallback
branch
from
838af70 to
7f6ea90
Compare
…allback App Variants typically do not have a manifest.json (they only add that during the build) but a manifest.appdescr_variant. During the project namespace detection, in case no manifest.json is present (error ENOENT), we now attempt a fallback to manifest.appdescr_variant (if present). For more information see: * https://help.sap.com/viewer/a7b390faab1140c087b8926571e942b7/202009.000/en-US/af47058ad66144579db6a990f3b7b919.html * https://blogs.sap.com/2020/07/15/adaptation-project-your-one-stop-tool-for-extending-sapui5-applications/ JIRA: CPOUI5FOUNDATION-284
RandomByte
force-pushed
the
app-variant-namespace-fallback
branch
from
7f6ea90 to
4127a48
Compare
RandomByte
changed the title
RandomByte
changed the title
aleksandr-suvorov
previously approved these changes
Dec 3, 2020
aleksandr-suvorov
approved these changes
Dec 4, 2020
matz3
approved these changes
Dec 7, 2020
| const project = createMockProject(); | ||
| const applicationFormatter = new ApplicationFormatter({project}); | ||
| const getJsonStub = sinon.stub(applicationFormatter, "getJson") | ||
| .onFirstCall().rejects({message: "No such stable or directory: manifest.json", code: "ENOENT"}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Variants typically do not have a manifest.json (they only add that during the build) but a manifest.appdescr_variant.
During the project namespace detection, in case no manifest.json is present (error ENOENT), we now attempt a fallback to manifest.appdescr_variant (if present).
For more information see:
JIRA: CPOUI5FOUNDATION-284