[FEATURE] Create designtime and support bundles for libraries #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a bundle would be empty (not contain any modules), it will be skipped.
codeworrior
commented
Oct 12, 2020
| ".view.json", | ||
| ".view.xml", | ||
| ".properties", | ||
| ".json" |
There was a problem hiding this comment.
The general ".json" file type is NOT present in our Maven tooling. I've kept it nevertheless for compatibility with existing projects that use the ui5-tooling already.
| return createLibraryBundles(libraryNamespace, resources) | ||
| .then((results) => { | ||
| const bundles = Array.prototype.concat.apply([], results); | ||
| return Promise.all(bundles.map((bundle) => bundle && workspace.write(bundle))); |
There was a problem hiding this comment.
Due to the new skipIfEmpty, some of the entries in the bundles array might be undefined.
|
I like this |
matz3
reviewed
Oct 16, 2020
RandomByte
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a bundle would be empty (not contain any modules), it will be skipped.