[FIX] Node.js API: TypeScript type definition support #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy-loading breaks the automatic type definition detection from TypeScript. Therefore we need to manually declare the exported types.
RandomByte
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
The commit message might confuse some into thinking this is a feature of the buil. E.g. generating typescript type definitions for UI5 projects.
Could we change the commit message to something which makes it clear that this is about the index.js or "ui5-builder API" itself and not a feature of the actual build?
Also, the purpose of the plugin should be roughly explained in the commit message.
matz3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy-loading breaks the automatic type definition detection from
TypeScript. Therefore we need to manually declare the exported types.