[FIX] XMLTemplateAnalyzer: Handle empty XML view/fragment #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeworrior
reviewed
Jun 10, 2020
| @@ -162,6 +162,13 @@ class XMLTemplateAnalyzer { | |||
| return; | |||
| } | |||
|
|
|||
| if ( !result ) { | |||
| // Skip empty xml views/fragments | |||
| log.warn("Ignoring empty file " + info.name); | |||
There was a problem hiding this comment.
isn't an empty view/fragment invalid? XML does not know allow empty files, IMO.
There was a problem hiding this comment.
Makes sense. I will change this to throw a proper error
codeworrior
reviewed
Jun 24, 2020
codeworrior
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/SAP/ui5-builder/issues/281
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist