[INTERNAL] Task createDebugFiles checks path before writes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 222
💛 - Coveralls |
|
This solves the first point in issue #36 |
|
Build time comparison with openui5-sample-app: master debug_file_check_existence_before_write SummaryThe extra check of path existence in the workspace doesn't prolong the build time. |
|
Could you squash those commits into one? |
stopcoder
force-pushed
the
debug_file_check_existence_before_write
branch
from
461a8ea to
eced8b5
Compare
|
Somehow the squash doesn't work well, I am working on it. |
stopcoder
force-pushed
the
debug_file_check_existence_before_write
branch
from
eced8b5 to
e45a0db
Compare
|
I forgot Now everything should be OK. |
RandomByte
requested changes
Jul 2, 2018
lib/processors/debugFileCreator.js
Outdated
| // previous tasks | ||
| return stat(resource.getPath().replace(options.pattern, options.replacement)) | ||
| .then( | ||
| // if the file can be found, it should be filtered out from createing debug file |
lib/processors/debugFileCreator.js
Outdated
| } | ||
| ); | ||
| }) | ||
| ).then((stats) => { |
There was a problem hiding this comment.
What about results instead of stats, as the array doesn't contain any stat info?
lib/processors/debugFileCreator.js
Outdated
| return stats.filter((stat) => { | ||
| return !!stat; | ||
| }); | ||
| }).then((filteredResource) => { |
There was a problem hiding this comment.
filteredResource => filteredResources
- The debugFileCreator processor checks whether the debug file path is used and only writes the content to the path when it's not used yet. - The debug file path can be used, for example, by the createBundle task which may create a specific bundle for the debug version of another bundle. In this case, the debugFileCreator shouldn't overwrite the created debug bundle.
stopcoder
force-pushed
the
debug_file_check_existence_before_write
branch
from
e45a0db to
e9db432
Compare
RandomByte
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
debugFileCreatorprocessor checks whether the debug file pathis used and only writes the content to the path when it's not
used yet.
The debug file path can be used, for example, by the
createBundletask which may create a specific bundle for the debug version of
another bundle. In this case, the
debugFileCreatorshouldn'toverwrite the created debug bundle.