[FEATURE] Add included/excludedDependencies parameter #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
When setting the buildDependencies parameter to "true" builder used to build all dependencies of the project. By adding two new parameters includedDependencies and excludedDependencies, similar to the existing included/excludedTasks parameters, one can now choose which depenendencies to include into the build. This is also useful for self-contained builds to include the built depenendy into the bundle, instead of the unbuilt source read from the file system (e.g. in case a transpile task is present).
After introducting included/excludedDependencies w/ commit 48cd30d, the buildDependencies parameter is no longer required. To build all dependencies excludedDependencies can be set to an empty array, to build no dependencies (default) excludedDependencies can be set to ["*"] This change prepares the deprecation of the parameter, by introducing a warning when buildDependencies is set (commented at the moment, as buildDependencies is still used by many internal dependencies) and by setting the new parameters feature comatible if buildDependencies is set
This change adds tests to builder for bulding bundles using parameters buildDependencies, included/excludedDependencies, selfContained and a combination thereof. All these have previously been untested.
This comes in handy, e.g. in case all UI5 libraries should be excluded from the build (excludedDependencies=[/^sap\.ui\./])
During usage of the builder having the buildDependencies parameter still in place, eventhough solely having included/excludedDependencies *could* replace the parameter, was prooven to be more intuitive. a) Leaving the parameter as is, won't break any existing implementation b) Setting the flag to true and *then* defining the includes / excludes somehow feel "more natural" c) Due to the default beeing set to an empty array, the logic in builder must not filter any dependencies if buildDependencies is set to false
matz3
requested changes
Dec 16, 2019
RandomByte
requested changes
Dec 16, 2019
RandomByte
approved these changes
Dec 16, 2019
matz3
approved these changes
Dec 16, 2019
RandomByte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting the buildDependencies parameter to "true" builder
used to build all dependencies of the project. By adding two new
parameters includedDependencies and excludedDependencies,
similar to the existing included/excludedTasks parameters, one
can now choose which depenendencies to include into the build.
This is also useful for self-contained builds to include the built
depenendy into the bundle, instead of the unbuilt source read
from the file system (e.g. in case a transpile task is present).
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist