[FIX] generateThemeDesignerResources: Allow core .theming in sources #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI issues will be solved by #1064 |
RandomByte
requested changes
Jul 22, 2024
This change respects an sap.ui.core library .theming file from the sources instead of simply overwriting the file. It allows the configuration to be put into the library and adjusted there instead of having to adjust it in the build task. The existing logic is kept to support older UI5 versions where the file is not available in the sources. JIRA: CPOUI5FOUNDATION-862
matz3
force-pushed
the
v3-fix-dot-theming
branch
from
a568aab to
225b409
Compare
RandomByte
approved these changes
Jul 22, 2024
matz3
added a commit
that referenced
this pull request
Jul 22, 2024
…1062) This change respects an sap.ui.core library .theming file from the sources instead of simply overwriting the file. It allows the configuration to be put into the library and adjusted there instead of having to adjust it in the build task. The existing logic is kept to support older UI5 versions where the file is not available in the sources. JIRA: CPOUI5FOUNDATION-862 (cherry picked from commit dda3011)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change respects an sap.ui.core library .theming file from the sources instead of simply overwriting the file.
It allows the configuration to be put into the library and adjusted there instead of having to adjust it in the build task.
The existing logic is kept to support older UI5 versions where the file is not available in the sources.
JIRA: CPOUI5FOUNDATION-862
mainas[INTERNAL]: [INTERNAL] generateThemeDesignerResources: Allow core .theming in sources #1066