-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sap.fhir.model.r4.FHIRListBinding): array index error while accessing structure definition url when no structure definition is maintained in a resource instance #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In list bindings in case if the structure definition call doesnt return any data for the default profile console errors are thrown with array index.
flovogt
requested changes
Jul 29, 2020
flovogt
previously approved these changes
Jul 29, 2020
flovogt
requested changes
Jul 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failing tests
done |
flovogt
requested changes
Aug 3, 2020
flovogt
requested changes
Aug 4, 2020
flovogt
reviewed
Aug 4, 2020
flovogt
requested changes
Aug 4, 2020
flovogt
approved these changes
Aug 4, 2020
openui5fhirbot
added a commit
that referenced
this pull request
Aug 4, 2020
## [1.1.6](v1.1.5...v1.1.6) (2020-08-04) ### Bug Fixes * **sap.fhir.model.r4.FHIRListBinding.js:** array index error while accessing structure definition url when no structure definition is maintained in a resource instance ([#155](#155)) ([0f4459c](0f4459c))
🎉 This PR is included in version 1.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In list bindings in case if the structure definition call doesnot return any data for the default profile console errors are thrown with array index exception