Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sap.fhir.model.r4.FHIRListBinding): array index error while accessing structure definition url when no structure definition is maintained in a resource instance #155

Merged
merged 14 commits into from
Aug 4, 2020

Conversation

AmirthavalliG
Copy link
Member

In list bindings in case if the structure definition call doesnot return any data for the default profile console errors are thrown with array index exception

In list bindings in case if the structure definition call doesnt return any data for the default profile console errors are thrown with array index.
@AmirthavalliG AmirthavalliG added bug Something isn't working Review Required labels Jul 27, 2020
@AmirthavalliG AmirthavalliG requested a review from flovogt July 27, 2020 16:14
@AmirthavalliG AmirthavalliG changed the title fix: array index error while acessing structure defintiion url fix: array index error while acessing structure definition url Jul 27, 2020
flovogt
flovogt previously approved these changes Jul 29, 2020
@flovogt flovogt self-requested a review July 29, 2020 10:27
@flovogt flovogt dismissed their stale review July 29, 2020 10:27

failing tests

Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing tests

@AmirthavalliG
Copy link
Member Author

failing tests

done

@AmirthavalliG AmirthavalliG requested a review from flovogt August 1, 2020 11:25
@coveralls
Copy link

coveralls commented Aug 1, 2020

Coverage Status

Coverage decreased (-0.03%) to 96.029% when pulling 63a9298 on fix/structure-def-url into e33e772 on master.

@flovogt flovogt changed the title fix: array index error while acessing structure definition url fix(sap.fhir.model.r4.FHIRListBinding.js): array index error while acessing structure definition url Aug 4, 2020
@flovogt flovogt changed the title fix(sap.fhir.model.r4.FHIRListBinding.js): array index error while acessing structure definition url fix(sap.fhir.model.r4.FHIRListBinding.js): array index error while accessing structure definition url when no structure definition is maintained in a resource instance Aug 4, 2020
@flovogt flovogt changed the title fix(sap.fhir.model.r4.FHIRListBinding.js): array index error while accessing structure definition url when no structure definition is maintained in a resource instance fix(sap.fhir.model.r4.FHIRListBinding): array index error while accessing structure definition url when no structure definition is maintained in a resource instance Aug 4, 2020
@AmirthavalliG AmirthavalliG merged commit 0f4459c into master Aug 4, 2020
@AmirthavalliG AmirthavalliG deleted the fix/structure-def-url branch August 4, 2020 11:05
openui5fhirbot added a commit that referenced this pull request Aug 4, 2020
## [1.1.6](v1.1.5...v1.1.6) (2020-08-04)

### Bug Fixes

* **sap.fhir.model.r4.FHIRListBinding.js:** array index error while accessing structure definition url when no structure definition is maintained in a resource instance ([#155](#155)) ([0f4459c](0f4459c))
@openui5fhirbot
Copy link
Collaborator

🎉 This PR is included in version 1.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Review Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants