Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handling changed resources when the server state and the client state is the same #154

Merged
merged 4 commits into from
Jul 29, 2020

Conversation

AmirthavalliG
Copy link
Member

hasResourceTypePendingChanges depends on the mChangedResources which gets updated even when the server data and the client data is the same.

@AmirthavalliG AmirthavalliG added bug Something isn't working Review Required labels Jul 27, 2020
@AmirthavalliG AmirthavalliG requested a review from flovogt July 27, 2020 14:50
Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AmirthavalliG AmirthavalliG merged commit f84d8a4 into master Jul 29, 2020
@AmirthavalliG AmirthavalliG deleted the fix/changed-resources branch July 29, 2020 09:28
openui5fhirbot added a commit that referenced this pull request Jul 29, 2020
## [1.1.5](v1.1.4...v1.1.5) (2020-07-29)

### Bug Fixes

* handling changed resources when the server state and the client state is the same ([#154](#154)) ([f84d8a4](f84d8a4))
@openui5fhirbot
Copy link
Collaborator

🎉 This PR is included in version 1.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Review Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants