Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-modeler): change clicking outside the toggle #2943

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nafis0077
Copy link

No description provided.

Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: 1d896f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/ui-components Patch
@sap-ux/ui-prompting Patch
@sap-ux-private/ui-prompting-examples Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cla-assistant bot commented Feb 18, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@815are 815are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nafis0077
changes looks ok, but there is missing changelog file,
to generate changelog file run pnpm cset in root folder of open-ux-tools

@nafis0077 nafis0077 marked this pull request as ready for review February 25, 2025 13:51
@nafis0077 nafis0077 requested a review from a team as a code owner February 25, 2025 13:51
@815are 815are added the ui-components @sap-ux/ui-components label Feb 26, 2025
unnecessary empty object
Copy link
Contributor

@815are 815are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked:

  1. style changes are straightforward
  2. changelog persists
  3. tested locally with storybook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui-components @sap-ux/ui-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants