Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Focus ring / target size too small #1277

Closed
bcullman opened this issue Feb 15, 2019 · 0 comments
Closed

Bug: Focus ring / target size too small #1277

bcullman opened this issue Feb 15, 2019 · 0 comments
Labels
a11y Accessibility related issues Bug Library

Comments

@bcullman
Copy link
Contributor

bcullman commented Feb 15, 2019

Is this issue related to a specific component?
TreeView

What version of the Fiori Fundamentals are you using?
1.4.2

To Reproduce
Steps to reproduce the behavior:
go to
https://sap.github.io/fundamental/components/tree.html

focus on one of the chevrons, and then use tab to gain focus on the close button.

Screenshots
image

Expected behavior
target area (made visible with focus ring) is 44px in height and width, minimum a11y.

to look nice, it should be square, filling the height of the entire row. a similar expand collapse chevron was used in SAP Concur's pre fundamentals library. here is where we landed:

image

@saad-mo saad-mo added Bug Library a11y Accessibility related issues labels Feb 27, 2019
@saad-mo saad-mo changed the title Focus ring / target size too small Bug: Focus ring / target size too small Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility related issues Bug Library
Projects
None yet
Development

No branches or pull requests

2 participants