This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
fix alert dismissible class #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-vue ready! Built with commit 750bf3a |
dandashino
force-pushed
the
feat/notifications
branch
3 times, most recently
from
306e242
to
eecb7f8
Compare
ChristianKienle
approved these changes
Aug 30, 2019
| @@ -18,7 +18,7 @@ exports[`Alert renders correctly 1`] = ` | |||
|
|
|||
| exports[`Alert renders correctly 2`] = ` | |||
| <div | |||
| class="fd-alert fd-alert--error fd-alert--dismissible" | |||
There was a problem hiding this comment.
what a nice bug. :D
| timeout: 2000, | ||
| permanent: false, | ||
| dismissible: true, | ||
| content: "Watashi ga kita!", |
update alert component test snapshot add notifications component and fdNotifications installation update documentation remove unnecessary checks unsubscribe to events on beforeDestroy updated documentation fixed deleting by group updated documentation and example fix: group name with value '' was clearing all groups in hideAll separated styles from sfc file call onDismiss callback once notification is removed update documentation: styles + onDismiss
dandashino
force-pushed
the
feat/notifications
branch
from
eecb7f8
to
ee9608c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated alert component test snapshot
add notifications component and fdNotifications installation
updated documentation
Please provide a link to the associated issue.
Please provide a brief summary of this pull request.
Give consumers the ability to hide/show alerts in various positions on the screen.
If this is a new feature, have you updated the documentation?
Yes, new examples have been added in the alert component documentation