-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(platform): smart filter bar #7504
Conversation
c9d6068
to
dbac5a0
Compare
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: c9d6068 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/61d43b230ffd1000074ce143 😎 Browse the preview: https://deploy-preview-7504--fundamental-ngx.netlify.app |
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: 4ccdb86 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/61de9c101c065000075c6957 😎 Browse the preview: https://deploy-preview-7504--fundamental-ngx.netlify.app |
1e83c4e
to
06d9b6e
Compare
06d9b6e
to
89cd428
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big one! Unfortunately wasn't able to play around with smart filter component due to errors while using filters
apps/docs/src/app/platform/component-docs/platform-table/platform-table.module.ts
Outdated
Show resolved
Hide resolved
.../components/smart-filter-bar-condition-field/smart-filter-bar-condition-field.component.html
Show resolved
Hide resolved
...ar/components/smart-filter-bar-settings-dialog/smart-filter-bar-settings-dialog.component.ts
Outdated
Show resolved
Hide resolved
libs/platform/src/lib/smart-filter-bar/directives/smart-filter-bar-subject.directive.ts
Outdated
Show resolved
Hide resolved
4a101f8
to
ec3d6da
Compare
ec3d6da
to
21d45e0
Compare
@InnaAtanasova example with dynamic page has been added. |
0954e13
to
88f01a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, thank you!
Found that example in dynamic page doesn't scroll properly.
Screen.Recording.2022-01-11.at.15.24.55.mov
It's more of the Dynamic Page issue itself. If I add more items to the table to increase the height of the dynamic page content, this behaviour won't be present |
8b0e7eb
to
97787da
Compare
97787da
to
390c7f8
Compare
Do we have a design for this ? I am not even sure why we should call this smart filter bar, in the platform should be everything smart by default, to make the life of the app developer easier. |
There's no design as it's a composition of components. In UI5 it's called Smart Filer Bar. I can send you a link to it in an email, can share it here :) |
I believe there should be a design even for composition of the components. we have many examples in the platform like that. Cuz at the end the component is used certain why by app developer or by other component and it needs to feel right. IT does not matter what is inside. ;-( |
00d3eef
to
4ccdb86
Compare
Related Issue(s)
closes #5291 closes #7442
Description
Created new 'Smart Filter Bar' component. -> https://deploy-preview-7504--fundamental-ngx.netlify.app/#/platform/smart-filter-bar
Refactored Platform Table data source and data provider classes.
Adjusted Platform form container component to support inline layout.
Refactored Platform table resize column service.
Adjusted Platform select component to support filling full width.
Adjusted Platform date picker to support filling full width.
Added new component to form generator - multi-input.
Screenshots
Please check whether the PR fulfills the following requirements
During Implementation
PR Quality
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
README.md