Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): rely on resize observer instead of window resize event #6940

Merged
merged 3 commits into from
Oct 21, 2021

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Oct 18, 2021

Related Issue.

Closes #6848

Description

Changed resize trigger. Now using ResizeObserver class instead of window resize event.
To check that resize spy works correctly, visit this example and check second column content: https://fundamental-ngx-gh--pr6940-fix-6848-resize-obse-dt0983a2.web.app/fundamental-ngx#/core/dynamic-page#layout

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors) -> There's an error message in console which is reproducible in main branch
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality
PR Review
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox

@netlify
Copy link

netlify bot commented Oct 18, 2021

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: f7e997d

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/61712d23b6aa780008023c4d

😎 Browse the preview: https://deploy-preview-6940--fundamental-ngx.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 18, 2021

Visit the preview URL for this PR (updated for commit f7e997d):

https://fundamental-ngx-gh--pr6940-fix-6848-resize-obse-dt0983a2.web.app

(expires Sun, 24 Oct 2021 09:11:52 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@N1XUS N1XUS self-assigned this Oct 18, 2021
@N1XUS N1XUS added the bug Something isn't working label Oct 18, 2021
@N1XUS N1XUS requested review from a team October 18, 2021 12:54
@N1XUS N1XUS merged commit abb99e5 into main Oct 21, 2021
@N1XUS N1XUS deleted the fix/6848-resize-observer-with-tabs branch October 21, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs component inside Dynamic Page and Flexible Column Layout
3 participants