-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fix Quick View Accessibility issues #5493
Conversation
✔️ Deploy Preview for fundamental-ngx ready! 🔨 Explore the source changes: 5b4079b 🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/60c306289e029100072e7932 😎 Browse the preview: https://deploy-preview-5493--fundamental-ngx.netlify.app |
3a40d79
to
576488e
Compare
.../src/lib/quick-view/quick-view-group-item-content/quick-view-group-item-content.component.ts
Outdated
Show resolved
Hide resolved
.../quick-view/quick-view-group-item-content/quick-view-group-item-content-element.directive.ts
Outdated
Show resolved
Hide resolved
libs/core/src/lib/quick-view/quick-view-group-item/quick-view-group-item.component.ts
Outdated
Show resolved
Hide resolved
...core/src/lib/quick-view/quick-view-group-item-label/quick-view-group-item-label.component.ts
Outdated
Show resolved
Hide resolved
...core/src/lib/quick-view/quick-view-group-item-label/quick-view-group-item-label.component.ts
Show resolved
Hide resolved
1970ec7
to
c8490a2
Compare
@olshansky Accessibility team has tested and below are the finding. Issue 1: fixed Issue 2: Issue: 3 : fixed Issue 4: Issue 5: Issue 6: fixed. Issue: 7 Issue 1-6 URL: https://deploy-preview-5493--fundamental-ngx.netlify.app/#/core/quick-view Thanks and Regards |
9ae31c5
to
db067cf
Compare
db067cf
to
b0768c0
Compare
e29c1d6
to
22514fd
Compare
.../src/lib/quick-view/quick-view-group-item-content/quick-view-group-item-content.component.ts
Outdated
Show resolved
Hide resolved
31ad661
to
82b4e5c
Compare
82b4e5c
to
9564381
Compare
9564381
to
7f1a8ac
Compare
7f1a8ac
to
7e777ec
Compare
b9a33b7
to
be7bcc2
Compare
be7bcc2
to
5b4079b
Compare
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
BREAKING CHANGE:
added
QuickViewGroupItemContentElementDirective
(fd-quick-view-group-item-content-element
) needed for bind the corresponding label to the element (email, phone, link, etc.)Please provide a link to the associated issue.
Closes: #4963
Please provide a brief summary of this pull request.
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
Documentation checklist:
README.md