Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix Quick View Accessibility issues #5493

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

artolshansky
Copy link
Contributor

@artolshansky artolshansky commented May 26, 2021

BREAKING CHANGE:
added QuickViewGroupItemContentElementDirective (fd-quick-view-group-item-content-element) needed for bind the corresponding label to the element (email, phone, link, etc.)

Please provide a link to the associated issue.

Closes: #4963

Please provide a brief summary of this pull request.

  • readable corresponding label
  • focus trap & close on ESC for popover and dialog variants

Please check whether the PR fulfills the following requirements

Documentation checklist:

@artolshansky artolshansky added the core Core library specific issues label May 26, 2021
@artolshansky artolshansky added this to the Sprint 63 - Ariba milestone May 26, 2021
@artolshansky artolshansky requested review from a team May 26, 2021 12:14
@artolshansky artolshansky self-assigned this May 26, 2021
@netlify
Copy link

netlify bot commented May 26, 2021

✔️ Deploy Preview for fundamental-ngx ready!

🔨 Explore the source changes: 5b4079b

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-ngx/deploys/60c306289e029100072e7932

😎 Browse the preview: https://deploy-preview-5493--fundamental-ngx.netlify.app

@artolshansky artolshansky requested a review from platon-rov May 26, 2021 15:50
@artolshansky artolshansky force-pushed the fix/quick-view-a11y branch 2 times, most recently from 1970ec7 to c8490a2 Compare May 28, 2021 07:54
@artolshansky artolshansky added the ready for qa Testing should be started for the PR label May 28, 2021
@Seamoo13 Seamoo13 requested a review from puru-hk May 29, 2021 08:35
@puru-hk puru-hk added Testing (QA) QA testing in progress rework required Validation failed and removed ready for qa Testing should be started for the PR labels May 31, 2021
@puru-hk
Copy link
Contributor

puru-hk commented Jun 1, 2021

@olshansky Accessibility team has tested and below are the finding.

Issue 1: fixed

Issue 2:
The issue is not fixed. An additional information is being read.
image

Issue: 3 : fixed

Issue 4:
The Company is read but the whole dialog details is read once.
image
Ideally, the dialog header along with the focused element information should be read when a dialog appears on the screen and no additional information should be read.
The dialog should have focus and should read the focused element.

Issue 5:
The issue is partially fixed and The Selected or Activated information of 'Open Popover', 'Open Pop over with heading' and 'Open Dialog' buttons is not read.

Issue 6: fixed.

Issue: 7
The horizontal scroll bars is available and the pop up is not visible properly.
image

Issue 1-6 URL: https://deploy-preview-5493--fundamental-ngx.netlify.app/#/core/quick-view
Issue 7: URL: https://deploy-preview-2385--fundamental-styles.netlify.app/?path=/docs/components-quick-view--popover
JAWS 2021

Thanks and Regards
Sanjay

@artolshansky artolshansky force-pushed the fix/quick-view-a11y branch 2 times, most recently from 9ae31c5 to db067cf Compare June 2, 2021 16:21
@artolshansky artolshansky removed the rework required Validation failed label Jun 2, 2021
@artolshansky artolshansky force-pushed the fix/quick-view-a11y branch from db067cf to b0768c0 Compare June 3, 2021 07:55
@artolshansky artolshansky force-pushed the fix/quick-view-a11y branch 2 times, most recently from e29c1d6 to 22514fd Compare June 3, 2021 12:06
@artolshansky artolshansky force-pushed the fix/quick-view-a11y branch 2 times, most recently from 31ad661 to 82b4e5c Compare June 3, 2021 17:58
@artolshansky artolshansky requested a review from dimamarksman June 3, 2021 18:02
@artolshansky artolshansky force-pushed the fix/quick-view-a11y branch from 82b4e5c to 9564381 Compare June 4, 2021 06:45
@artolshansky artolshansky force-pushed the fix/quick-view-a11y branch from 9564381 to 7f1a8ac Compare June 4, 2021 12:10
@artolshansky artolshansky changed the title fix: (Core) Quick View Accessibility issues fix(core): Quick View Accessibility issues Jun 4, 2021
@artolshansky artolshansky force-pushed the fix/quick-view-a11y branch from 7f1a8ac to 7e777ec Compare June 5, 2021 07:49
@artolshansky artolshansky added ready for qa Testing should be started for the PR and removed Testing (QA) QA testing in progress labels Jun 7, 2021
@manjunathanagaraj manjunathanagaraj removed this from the Sprint 63 - Ariba milestone Jun 8, 2021
@artolshansky artolshansky force-pushed the fix/quick-view-a11y branch from b9a33b7 to be7bcc2 Compare June 8, 2021 13:14
@puru-hk
Copy link
Contributor

puru-hk commented Jun 9, 2021

Issue 5 is still not fixed.
MicrosoftTeams-image.png

@puru-hk puru-hk added rework required Validation failed and removed ready for qa Testing should be started for the PR labels Jun 9, 2021
@artolshansky artolshansky force-pushed the fix/quick-view-a11y branch from be7bcc2 to 5b4079b Compare June 11, 2021 06:43
@artolshansky artolshansky changed the title fix(core): Quick View Accessibility issues fix(core): fix Quick View Accessibility issues Jun 11, 2021
@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@github-actions github-actions bot added the stale label Jun 14, 2021
@artolshansky artolshansky added ready for qa Testing should be started for the PR and removed rework required Validation failed stale labels Jun 15, 2021
@artolshansky artolshansky merged commit 7ca006d into main Jun 16, 2021
@artolshansky artolshansky deleted the fix/quick-view-a11y branch June 16, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core library specific issues ready for qa Testing should be started for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility: Quick View
7 participants