New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo and coding rule #9

Open

befehlen opened this issue Oct 25, 2018 · 1 comment

Member

befehlen commented Oct 25, 2018 •

edited

Loading

1. Typo

line 34: I think // for tokenization or // for tokenizing is better than // for tokenize.
line 53: I don't get what // For use in libraries implementing .is() means. Which libraries?
line 58: // concern matchs should be // concern matches
line 174: need to change charactor to character.

2. Coding rule

line 372: results= [] --> results = [], var fn --> var fn (tab to space)
General: I see there's no coding rule for anonymous function.
You need to choose one of function() or function ().

The text was updated successfully, but these errors were encountered:

Contributor

wonseop commented Oct 30, 2018 •

edited

Loading

This is true.
Please submit a request for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment