Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong direction #10

Open
honeyspoon opened this issue Apr 1, 2021 · 5 comments
Open

Wrong direction #10

honeyspoon opened this issue Apr 1, 2021 · 5 comments

Comments

@honeyspoon
Copy link

Seems like the mapping switches direction at some point.

Not sure if I'm using it wrong
Here is a gif of the bahaviour
resizer

I use both of theese

Plug 'christoomey/vim-tmux-navigator'
Plug 'RyanMillerC/better-vim-tmux-resizer'

with the default settings

also

set -g @plugin 'christoomey/vim-tmux-navigator'
set -g @plugin 'RyanMillerC/better-vim-tmux-resizer'

with the default settings

@comfortablynick
Copy link

I have experienced the same thing; it seems to switch direction when a vertical split is added to a horizontal split.

@honeyspoon
Copy link
Author

we should make a state diagram or statechart to see all the possible states and transition between them

@RyanMillerC
Copy link
Owner

I can confirm this is an issue I’ve noticed. Haven’t gotten a chance to debug and see why this happening. In the meantime to resize Vim Tmux panes I’ve been swapping to the non-Vim Tmux pane and resizing it. That is my hack workaround. 😅

@RyanMillerC
Copy link
Owner

Fixed! a791fe5

There was already logic to prevent this when resizing up. Added condition when resizing down.

@RyanMillerC
Copy link
Owner

On second review, the above commit only fixes the issue if Vim is only vertically split. I am still able to replicate the second half of GIF above with Vim split vertically and one side split horizontally. Will need to look further into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants