Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxTheme #45

Closed
9 tasks done
wddwycc opened this issue Mar 8, 2018 · 6 comments
Closed
9 tasks done

RxTheme #45

wddwycc opened this issue Mar 8, 2018 · 6 comments

Comments

@wddwycc
Copy link
Member

wddwycc commented Mar 8, 2018

My colleague was using SwiftTheme on iOS,
but the lib is very hard to extend and its implementation is not that clean.

I know RxCocoa is perfect for such binding switch,
so I write this lightweight lib with a ThemeService<T> class and a bunch of Binder<T> presets.

https://github.com/wddwycc/RxTheme

It's now used in most downloaded coin analysis app in Japan Coinview

  • replace copyright with "Copyright (c) RxSwiftCommunity" in code
  • replace copyright in README
  • replace copyright in LICENSE
  • update the remote URL of the Podspec (if any)
  • update CI badge
  • update CI settings
  • transfer repository ownership (once you're a contributor)
  • fork the repo back to your personal account
  • add project to https://github.com/RxSwiftCommunity/rxswiftcommunity.github.io
@ashfurrow
Copy link
Member

Looks awesome! I've invited you to the org, let me know what we can do to help!

@freak4pc
Copy link
Member

freak4pc commented Mar 8, 2018

Welcome @wddwycc ! As @ashfurrow mentioned, let us know if you need help in transferring ownership.

There's one extra step that we didn't update in the documentation:

You can read more on this decision here but I also plan on updating the entire documentation for this soon :)

@wddwycc
Copy link
Member Author

wddwycc commented Mar 9, 2018

@ashfurrow @freak4pc thank you guys.

@wddwycc
Copy link
Member Author

wddwycc commented Mar 9, 2018

@ashfurrow @freak4pc

Finished tasks and PR is here

@bobgodwinx
Copy link
Member

Really nice I love the idea, congrats. 👍 next is to support Carthage if you can. But no rush. you can create an issue and someone can pick it up from there.

@freak4pc
Copy link
Member

Closing this one. Thanks @wddwycc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants