Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix duplicated RxWKNavigationDelegateProxy in RxCocoa and RxWebKit #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix duplicated RxWKNavigationDelegateProxy in RxCocoa and RxWebKit #56

wants to merge 1 commit into from

Conversation

mt-hodaka
Copy link

@mt-hodaka mt-hodaka commented Mar 4, 2022 •
edited
Loading

fix #52

This is because RxWKNavigationDelegateProxy was duplicated in RxCocoa and RxWebKit.

Fixed to use RxCocoa implementation.

@mt-hodaka mt-hodaka changed the title fix duplicated RxWKNavigationDelegateProxy in RxSwift and RxWebKit fix duplicated RxWKNavigationDelegateProxy in RxCocoa and RxWebKit Mar 4, 2022
@mt-hodaka
Copy link
Author

Tests failed because file reference is broken. (will be fixed in #55)

@mt-hodaka mt-hodaka marked this pull request as ready for review March 4, 2022 08:19
@mt-hodaka mt-hodaka marked this pull request as draft March 4, 2022 08:29
@mt-hodaka mt-hodaka force-pushed the fix-navigation-delegate-proxy branch from cbf02e8 to a0cc758 Compare March 4, 2022 08:45
@mt-hodaka mt-hodaka force-pushed the fix-navigation-delegate-proxy branch from a0cc758 to 30114bd Compare March 4, 2022 08:51
@mt-hodaka mt-hodaka marked this pull request as ready for review March 4, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mt-hodaka