Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Swift 3 #44

Closed
gorbat-o opened this issue Oct 6, 2016 · 6 comments · Fixed by #45
Closed

Update Swift 3 #44

gorbat-o opened this issue Oct 6, 2016 · 6 comments · Fixed by #45

Comments

@gorbat-o
Copy link

gorbat-o commented Oct 6, 2016

Hey,

Maybe an update for swift 3 ? =D

Thanks

@esttorhe
Copy link
Member

Hi @gorbat-o I'm in the middle of relocating to 🇩🇪 and haven't had much time to work on my OSS projects (also I don't currently have internet at the apartment).

I think Greg already started tackling this with #43.

If you could test that the branch works and behaves as expected and can vouch for the fix I can totally merge that and release the Swift 3 support. 😄

@nechris
Copy link

nechris commented Oct 28, 2016

Seemingly var disposeKey: Bag<Disposable>.KeyType? doesn't work anymore as Bag and KeyType seem to be private now. When explicitly setting the Bag struct and KeyType type alias in RxSwift to public, it works.
Any thoughts on this?

@YMonnier
Copy link

Soon Swift 4?

@freak4pc
Copy link
Member

Doesn't seem like this project is maintained anymore :(

@esttorhe
Copy link
Member

Apologies to all @nechris, @YMonnier and @freak4pc

Currently, I don't have much time to put into OSS (sadly) and haven't had the time to keep maintaining this.

I've tried to hand it over to the community seeing that it has been used by a couple more than just me and some friends (which is awesome), but haven't been lucky yet.

If someone sends a PR with support for 3 and/or 4 I would love to merge; also everyone who gets a merged PR is invited to be part of RxSwiftCommunity and can help maintain this and other projects (if the person wishes to)

Besides this I can't guarantee when I will have time to update this; suffice it to say that if I can squeeze some time for OSS the first project I will tackle will this

@freak4pc
Copy link
Member

freak4pc commented Jun 26, 2017

@esttorhe Just pushed a PR for Swift 3 & 4. Let me know if any questions arise :)
#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants