Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIViewPropertyAnimator extension #148

Closed
twittemb opened this issue Mar 27, 2018 · 7 comments
Closed

UIViewPropertyAnimator extension #148

twittemb opened this issue Mar 27, 2018 · 7 comments
Labels

Comments

@twittemb
Copy link

twittemb commented Mar 27, 2018

Hi

Name and description: UIViewPropertyAnimator extension

The purpose of this extension is to wrap a UIViewPropertyAnimator into a Completable to be able to chain animations very easily and in a RxSwift way: see https://medium.com/@thibault.wittemberg/elegantly-chaining-uiviewpropertyanimators-88409c64f845

Motivation for inclusion:

I can't find UIViewPropertyAnimator extension anywhere, so I wonder if RxSwiftExt is the best target for this kind of feature ? @freak4pc seems to think so on the Slack channel. I need a confirmation here, and I'd like to know in which folder I should put my files, since it is not a new Rx operator but rather a Rx extension.

Example of use:

        self.animator1.rx.animate
            .andThen(self.animator2.rx.animate)
            .andThen(self.animator3.rx.animate)
            .andThen(self.animator4.rx.animate)
            .subscribe()
            .disposed(by: self.disposeBag)
@twittemb
Copy link
Author

Does someone have an opinion on that ? perhaps RxSwiftExt is not the appropriate repo for that kind of extension ... I have no problem with that, I just wanted to know if there is a good repo for this kind of feature 😀 (or perhaps this feature is to basic to be considered as a good add-on ... I'm ready to hear that too👌)

thanks for your help.

@freak4pc
Copy link
Member

Hey :) As discussed on slack I think this is a great addition.
Additions to this repo take time unfortunately as It's mainly me for the past few weeks - other members are sometimes busier so review times may vary :)

I think this would fit very well here and I would also like adding the operators potentially :)

@freak4pc
Copy link
Member

Regarding location it would probably be a UIViewPropertyAnimator+Rx.swift file in RxCocoa much like this one: https://github.com/RxSwiftCommunity/RxSwiftExt/blob/master/Source/RxSwift/ObservableType%2BWeak.swift

@twittemb
Copy link
Author

Hi @freak4pc

Thanks for your response. Good to hear from you 👍

I will do a PR ASAP with these recommendations.

I know how challenging can be an OpenSource project ... RxFlow takes me a LOT of time ! hard to be everywhere 😀

Thanks.

@freak4pc
Copy link
Member

P.S We might want to make a Components folder inside. There was some discussion over here but not enough opinions. You can just put it in the RxCocoa folder ATM:

#130

@twittemb
Copy link
Author

Hi

The PR is here: #151

Thanks guys.

@twittemb
Copy link
Author

I close this issue because a PR has been made ... this is always nice to have less issues in a repo 😀👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants