You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PCLMULQDQ works with XMM registers and I thought that XSAVE support (with 0b10 bits) is needed for properly saving and restoring XMM registers, e.g. during context switches.
Looking at is_x86_feature_detected's source code, it looks like it does not have a similar XSAVE check for XMM registers, so I guess we can drop it as well.
For example, this is fails on an M1 running under Rosetta (macOS Sequoia 15.0):
macOS (under Rosetta) does not support OSXSAVE or AVX, so
has_pclmulqdq
returns false. ButPCLMULQDQ
does not require AVX, only SSE2 + CLMUL.Indeed, Go does not require OSXSAVE for PCLMULQDQ
See also: golang/go#41022
The text was updated successfully, but these errors were encountered: