Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect documentation for ecdsa::RecoveryId #852

Open
zigtur opened this issue Aug 21, 2024 · 1 comment
Open

Incorrect documentation for ecdsa::RecoveryId #852

zigtur opened this issue Aug 21, 2024 · 1 comment

Comments

@zigtur
Copy link

zigtur commented Aug 21, 2024

At recovery.rs#L45, the documentation indicates:

/// - hi bit (3/4): did the affine x-coordinate of 𝑘×𝑮 overflow the order of
/// the scalar field, requiring a reduction when computing r?

However, having hi bit (3/4) is not possible. It should be hi bit (2/3) instead.
@tarcieri
Copy link
Member

Yes, feel free to submit a PR to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarcieri @zigtur