Re-implement concat_idents! in libmacros #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an unstable feature used by kernel modules. The new proc macro also has different behavior with respect to macro hygiene. Unlike the unstable concat_idents! macro it for example allows referring to local variables by taking the span of the second macro as span for the output identifier. Signed-off-by: Björn Roy Baron <[email protected]>
wedsonaf
reviewed
Jul 11, 2022
| /// | ||
| /// This is useful in macros that need to declare or reference items with names | ||
| /// starting with a fixed prefix and ending in a user specified name. The resulting | ||
| /// identifier has the span of the second argument. |
There was a problem hiding this comment.
Wouldn't be better to have the span of the proc macro invocation?
There was a problem hiding this comment.
That would be confusing if the caller of concat_idents! is invoked from another macro, but the identifier originates from outside of this macro.
There was a problem hiding this comment.
Oh, I see. In the example below it would point to one of the BR_ identifiers.
This also assumes that we are prefixing identifiers, but I think it's ok as that's the only usage ATM.
wedsonaf
approved these changes
Jul 12, 2022
90 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an unstable feature used by kernel modules. The new proc
macro also has different behavior with respect to macro hygiene. Unlike
the unstable concat_idents! macro it for example allows referring to
local variables by taking the span of the second macro as span for the
output identifier.
Signed-off-by: Björn Roy Baron [email protected]