Bounce through SDL2 heap in AudioCVT::convert #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit rewrites AudioCVT::convert to bounce the audio buffer into a an SDL2 heap allocation, rather than trying to reuse the rust heap buffer. This is critical, as the underlying library warns internally that the buffer may be reallocated, breaking configurations where the library is not using the same heap as rust. The underlying implementation also notes that the underlying buffer may be transparently resized to larger than the output as part of the transformations, so relying on the buffer being capacity() bytes long to ensure the buffer is not re-allocated is a broken assumption. Closes Rust-SDL2#1096
|
Thanks! I didn't expect it to be done this quickly, I was prepared to do it myself this weekend if no one did it themselves. Regardless, I think it looks good to go! We may have to change the doc in the future, the changes aren't really done "in place" anymore, but well, this isn't too important. Merging! |
sypwex
pushed a commit
to sypwex/rust-sdl2
that referenced
this pull request
Jun 2, 2024
Bounce through SDL2 heap in AudioCVT::convert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit rewrites AudioCVT::convert to bounce the audio buffer into a
an SDL2 heap allocation, rather than trying to reuse the rust heap
buffer. This is critical, as the underlying library warns internally
that the buffer may be reallocated, breaking configurations where
the library is not using the same heap as rust.
The underlying implementation also notes that the underlying buffer may
be transparently resized to larger than the output as part of the
transformations, so relying on the buffer being capacity() bytes long to
ensure the buffer is not re-allocated is a broken assumption.
Closes #1096