Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Diamond SVG is cropped on both ends. #29

Closed
kevinolsson opened this issue Apr 19, 2015 · 10 comments
Closed

The Diamond SVG is cropped on both ends. #29

kevinolsson opened this issue Apr 19, 2015 · 10 comments

Comments

@kevinolsson
Copy link

Looking at Diamond from Fontawesome http://fortawesome.github.io/Font-Awesome/icon/diamond/
The one here is cropped.

@llwt
Copy link

llwt commented Jun 2, 2015

The credit card svgs are cropped as well.

@jelv
Copy link

jelv commented Jun 30, 2015

The same for Graduation cap in SVG and PNG.

@ThibaultR
Copy link

Same for picture-o.svg and camera.svg and probably a few others...

@FelisPhasma
Copy link

Also weixin.svg

@sprinz
Copy link

sprinz commented Jul 9, 2015

Also every variant of cloud.svg

@konpa
Copy link

konpa commented Aug 6, 2015

same for Behance

@fahim0623
Copy link

Its there for a lot of them.
Anyone has any idea or quick fix?

@FelisPhasma
Copy link

There appears to be a lot of them. How about just scaling it down so it fits in the SVG?

@Nimdraug
Copy link

The issue is that it has been assumed that all font-awesome icons fit in a square, which is true for most of them, but there are quite a few of them that do not, as we have discovered.
Personally I don't think scaling them down is the answer because we need them to have roughly the same height for layout purposes etc. For instance I need the social icons to have the same height, and having the G+ icon be smaller would make things looks out of whack.
What I think should happen is that the view boxes should conform to the actual size of the icon. However, I don't know how easy that will be to work out in the generate script.

@Rush
Copy link
Owner

Rush commented May 30, 2017

@Nimdraug fixed :) I removed the assumption of icons being square., although pixel-grid padding code will try to keep the originally-square icons to be still square.

@Rush Rush closed this as completed May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants