Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Port new selenium tests over to BookServer #30

Closed
bnmnetp opened this issue May 3, 2021 · 10 comments
Closed

Port new selenium tests over to BookServer #30

bnmnetp opened this issue May 3, 2021 · 10 comments
Assignees

Comments

@bnmnetp
Copy link
Member

bnmnetp commented May 3, 2021

This would be a big hit for coverage as well as testing ajax.py

@bjones1 do you have any interest in getting these moved over?

@bjones1 bjones1 self-assigned this May 3, 2021
@bjones1
Copy link
Collaborator

bjones1 commented May 3, 2021

Sure, I'll be happy to.

@bjones1
Copy link
Collaborator

bjones1 commented May 3, 2021

A quick look: the current release of runestone components depends on SQLAlchemy 1.3, while we need 1.4. So, we need a release of Runestone Components with updated dependencies to make much progress. Can you work on this?

@bjones1
Copy link
Collaborator

bjones1 commented May 3, 2021

Another challenge: there's no way to create a user in the bookserver. I assume I'll need to get the SQL to do it from then execute that.

@bnmnetp
Copy link
Member Author

bnmnetp commented May 3, 2021

Yes, I just have a .csv file with my own username in it that I load. But I think we will want a way to initialize the usual courses as well as making some users.

@bnmnetp
Copy link
Member Author

bnmnetp commented May 3, 2021

Do you need a released runestone or if I have requirements-dev.txt updated on github will that work?

@bjones1
Copy link
Collaborator

bjones1 commented May 3, 2021

Github should be fine, per python-poetry/poetry#47.

@bnmnetp
Copy link
Member Author

bnmnetp commented May 3, 2021

I just released 5.6.1 so we should be good either way.

@bjones1
Copy link
Collaborator

bjones1 commented May 3, 2021

OK, thanks! I'll try it out as soon as it shows up; poetry doesn't see it yet.

@bnmnetp
Copy link
Member Author

bnmnetp commented May 3, 2021

OK, I can see it on the pypi webpage, but sometimes it takes a bit before the CL utils can see it.

@bjones1
Copy link
Collaborator

bjones1 commented May 13, 2021

AFAIK, this is done!

@bjones1 bjones1 closed this as completed May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants