Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check on quantile values #73

Open
rubenpeters91 opened this issue Dec 9, 2022 · 0 comments
Open

Add a check on quantile values #73

rubenpeters91 opened this issue Dec 9, 2022 · 0 comments
Labels
Good First Issue Good to start with if you're new to sam Priority: Low Issues that have no or little impact on current version. No fix or workaround required Type: Maintenance Issues regarding outdated code, documentation or dependency related issues

Comments

@rubenpeters91
Copy link
Contributor

You can supply the sam models with quantile values outside of the 0,1 range, but this will lead to -Inf losses, maybe good to add a line that checks if all the quantile values lie within the [0, 1] range and if not, throw an error
@rubenpeters91 rubenpeters91 added Priority: Low Issues that have no or little impact on current version. No fix or workaround required Type: Maintenance Issues regarding outdated code, documentation or dependency related issues Good First Issue Good to start with if you're new to sam labels Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good to start with if you're new to sam Priority: Low Issues that have no or little impact on current version. No fix or workaround required Type: Maintenance Issues regarding outdated code, documentation or dependency related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rubenpeters91