Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unittests will fail when KNMI API returns empty results #63

Open
2 tasks
sbuergers opened this issue Aug 19, 2022 · 0 comments
Open
2 tasks

Unittests will fail when KNMI API returns empty results #63

sbuergers opened this issue Aug 19, 2022 · 0 comments
Labels
Good First Issue Good to start with if you're new to sam Priority: Low Issues that have no or little impact on current version. No fix or workaround required

Comments

@sbuergers
Copy link
Collaborator

sbuergers commented Aug 19, 2022 •
edited
Loading

This is not reflective of SAM code not working, so rather than throwing an error, this should only raise a warning that KNMI API is down.

affected:

  • sam.data_sources.weather.knmi.read_knmi
  • TestWeather.test_read_knmi_hourly
@sbuergers sbuergers added Priority: Medium Issues that need to be fixed, but low impact or a workaround exists Good First Issue Good to start with if you're new to sam labels Aug 19, 2022
@rubenpeters91 rubenpeters91 added Priority: Low Issues that have no or little impact on current version. No fix or workaround required and removed Priority: Medium Issues that need to be fixed, but low impact or a workaround exists labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good to start with if you're new to sam Priority: Low Issues that have no or little impact on current version. No fix or workaround required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbuergers @rubenpeters91