Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MLPTimeseriesRegressor score function #37

Open
rubenpeters91 opened this issue Jul 25, 2022 · 0 comments
Open

Refactor MLPTimeseriesRegressor score function #37

rubenpeters91 opened this issue Jul 25, 2022 · 0 comments
Labels
Good First Issue Good to start with if you're new to sam Priority: Low Issues that have no or little impact on current version. No fix or workaround required Type: Improvement Any technical improvement without changing functionality

Comments

@rubenpeters91
Copy link
Contributor

The score function calculates the tilted/pinball loss without using the included joint_tilted_loss function of this package. It would be a lot cleaner to use the internal function, instead of calculating it in multiple places
@rubenpeters91 rubenpeters91 added Priority: Low Issues that have no or little impact on current version. No fix or workaround required Type: Improvement Any technical improvement without changing functionality labels Jul 25, 2022
@abontsema abontsema changed the title Refactor TimeseriesMLP score function Refactor MLPTimeseriesRegressor score function Jul 29, 2022
@abontsema abontsema added the Good First Issue Good to start with if you're new to sam label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good to start with if you're new to sam Priority: Low Issues that have no or little impact on current version. No fix or workaround required Type: Improvement Any technical improvement without changing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abontsema @rubenpeters91