Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider effect of removing first rows after rolling features #28

Open
rubenpeters91 opened this issue Jul 22, 2022 · 0 comments
Open

Consider effect of removing first rows after rolling features #28

rubenpeters91 opened this issue Jul 22, 2022 · 0 comments
Labels
Priority: Low Issues that have no or little impact on current version. No fix or workaround required Type: Question

Comments

@rubenpeters91
Copy link
Contributor

With version 3.0, when using the TimeSeriesMLP the first rows of the data will be removed in fit because of the rolling features, this no longer happens in the feature engineer, since it can also contain custom functions. This behaviour of course changes when using an imputer. We should consider if this is what we want
@rubenpeters91 rubenpeters91 added Priority: Low Issues that have no or little impact on current version. No fix or workaround required Type: Question labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Issues that have no or little impact on current version. No fix or workaround required Type: Question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rubenpeters91