You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
core::membrane::convex_hull() causes a segfault in core::Size minx = outside[ tmp_x.index( numeric::min( tmp_x ) ) ]; because the tmp_x vector is empty. This is because none of the coordinates pass the coords.at( i ).z() >= min_z && coords.at( i ).z() <= max_z test previously, as the min_z and max_z settings are well outside the range of the protein coordinates (-15 to -5, where almost all the protein z-coordinates are positive).
Part of the reason may be a non-consistent span file. (But even then, the code shouldn't segfault.)
One question is if the reliance on absolute Cartesian z coordinates here is warranted, or if what we really want is the membrane-transformed z offset (is the assumption that the membrane is centered on z=0?) -- But even if that's corrected, the code should be robust to 'membrane' proteins which aren't actually in the membrane.
From discussion #163
core::membrane::convex_hull()
causes a segfault incore::Size minx = outside[ tmp_x.index( numeric::min( tmp_x ) ) ];
because the tmp_x vector is empty. This is because none of the coordinates pass thecoords.at( i ).z() >= min_z && coords.at( i ).z() <= max_z
test previously, as the min_z and max_z settings are well outside the range of the protein coordinates (-15 to -5, where almost all the protein z-coordinates are positive).Part of the reason may be a non-consistent span file. (But even then, the code shouldn't segfault.)
One question is if the reliance on absolute Cartesian z coordinates here is warranted, or if what we really want is the membrane-transformed z offset (is the assumption that the membrane is centered on z=0?) -- But even if that's corrected, the code should be robust to 'membrane' proteins which aren't actually in the membrane.
Reproduction steps:
And options:
with command
The text was updated successfully, but these errors were encountered: