From e57804bbc3c9f2225333bcaea2c7f276d08d8b5c Mon Sep 17 00:00:00 2001
From: Rosalie Wanders <rosalie@mailbox.org>
Date: Tue, 23 Jul 2024 11:14:44 +0200
Subject: [PATCH] SporeModManager: improve test_update_modapi test in test.py

---
 SporeModManager/test.py | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/SporeModManager/test.py b/SporeModManager/test.py
index 4898ac0..5aa9407 100755
--- a/SporeModManager/test.py
+++ b/SporeModManager/test.py
@@ -639,13 +639,7 @@ def test_update_modapi():
 	print(f'Running {test_update_modapi.__name__}...')
 	reset_smm()
 
-	# attempt to update modapi dll
-	result = run_smm([ 'update-modapi' ])
-	assert result.returncode == 0
-	assert result.stdout != b''
-	assert result.stderr == b''
-
-	# ensure mod with higher dll build required works
+	# ensure mod with higher dll build required doesn't work
 	xml = """<mod displayName="test_update_modapi_0" 
 				unique="test_update_modapi_0" 
 				description="test_update_modapi_0" 
@@ -654,6 +648,18 @@ def test_update_modapi():
 			</mod>"""
 	write_sporemod(xml)
 	result = run_smm([ 'install', sporemod_file ])
+	assert result.returncode != 0
+	assert result.stdout == b''
+	assert result.stderr != b''
+
+	# attempt to update modapi dll
+	result = run_smm([ 'update-modapi' ])
+	assert result.returncode == 0
+	assert result.stdout != b''
+	assert result.stderr == b''
+
+	# ensure mod with higher dll build required works
+	result = run_smm([ 'install', sporemod_file ])
 	assert result.returncode == 0
 	assert result.stdout != b''
 	assert result.stderr == b''