fix(transports): bad interface implementation (#19)

Romaixn · Nov 23, 2023 · 3a27cda · 3a27cda
1 parent db093e5
commit 3a27cda
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/amqp_transport.go b/amqp_transport.go
@@ -17,6 +17,7 @@ type RabbitMQ struct {
 
 var connection *amqp.Connection
 var channel *amqp.Channel
+var _ Transport = (*RabbitMQ)(nil)
 
 func (rabbitmq RabbitMQ) connect() error {
 	var err error
@@ -38,7 +39,7 @@ func (rabbitmq RabbitMQ) connect() error {
 	return nil
 }
 
-func (rabbitmq RabbitMQ) listen(fn process, message any) error {
+func (rabbitmq RabbitMQ) listen(fn process, message any, _ int) error {
 	err := rabbitmq.connect()
 	if err != nil {
 		return err

diff --git a/amqp_transport_test.go b/amqp_transport_test.go
@@ -35,7 +35,7 @@ func TestAmqpListen(t *testing.T) {
 	}
 
 	go func() {
-		err := transport.listen(processMessage, Message{})
+		err := transport.listen(processMessage, Message{}, 0)
 		if err != nil {
 			t.Errorf("Expected no error, got %v", err)
 		}

diff --git a/pgsql_transport.go b/pgsql_transport.go
@@ -19,6 +19,7 @@ type PgDatabase struct {
 }
 
 var pool *pgxpool.Pool
+var _ Transport = (*PgDatabase)(nil)
 
 func (database PgDatabase) connect() error {
 	var err error
@@ -72,17 +73,12 @@ func (database PgDatabase) listen(fn process, message any, sec int) error {
 }
 
 func (database PgDatabase) listenEvery(seconds int, fn process, message any) {
-	ticker := time.NewTicker(time.Duration(seconds) * time.Second)
+	delay := time.Duration(seconds) * time.Second
 
 	go func() error {
 		for {
-			select {
-			case <-ticker.C:
-				err := database.processMessage(fn, message)
-				if err != nil {
-					continue
-				}
-			}
+			<- time.After(delay)
+			_ = database.processMessage(fn, message)
 		}
 	}()
 }

diff --git a/redis_transport.go b/redis_transport.go
@@ -17,6 +17,7 @@ type Redis struct {
 }
 
 var rdb *redis.Client
+var _ Transport = (*Redis)(nil)
 
 func (red Redis) connect() error {
 	var err error
@@ -36,7 +37,7 @@ func (red Redis) connect() error {
 	return nil
 }
 
-func (red Redis) listen(fn process, message any) error {
+func (red Redis) listen(fn process, message any, _ int) error {
 	err := red.connect()
 	if err != nil {
 		return err

diff --git a/redis_transport_test.go b/redis_transport_test.go
@@ -33,7 +33,7 @@ func TestRedisListen(t *testing.T) {
 	}
 
 	go func() {
-		err := transport.listen(processMessage, Message{})
+		err := transport.listen(processMessage, Message{}, 0)
 		if err != nil {
 			t.Errorf("Expected no error, got %v", err)
 		}