Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory Loss When Using FakeKreativ with Multiverse-Inventories #5

Open
4 tasks done
FemBoysAreCute opened this issue Jan 3, 2025 · 3 comments
Open
4 tasks done
Assignees

Comments

@FemBoysAreCute
Copy link
Contributor

Server Version

Paper 1.21.4

Resource Version

FakeCreative v1.0.9-SNAPSHOT-b91

Dump Information

https://ci.craftationgaming.com/dump?id=rabatewilu

Describe The Bug

The bug causes the inventory of players to be cleared when switching worlds in a setup using Multiverse-Inventories. This issue occurs immediately after the FakeKreativ plugin is installed and is triggered when players travel between worlds managed by Multiverse. The plugin appears to conflict with Multiverse-Inventories, resulting in data loss.

Expected Behavior

Players' inventories should remain intact when switching between worlds, as managed by Multiverse-Inventories. The FakeKreativ plugin should not interfere with or overwrite inventory data from other plugins. It should seamlessly integrate into the server without causing conflicts or data loss.

Steps To Reproduce

  1. Install the FakeKreativ plugin on a Minecraft server.
  2. Install and configure Multiverse-Inventories to manage inventory data across multiple worlds.
  3. Ensure at least three players have distinct items in their inventories.
  4. Have the players switch between worlds (e.g., from a survival world to a creative world).
  5. Observe the players' inventories after switching worlds.

Result: The players' inventories are cleared upon switching worlds.

Additional Info

  • The issue occurs consistently across multiple server versions (tested on [insert specific Minecraft server version, e.g., 1.20.1]).
  • No errors or warnings related to the conflict appear in the server logs, making troubleshooting more difficult.
  • Disabling FakeKreativ resolves the issue, indicating a direct conflict with Multiverse-Inventories.
  • Relevant screenshots can include:
    1. The players' inventory before and after switching worlds.
    2. The server console showing plugin initialization and any debug output.
    3. Configuration files for both FakeKreativ and Multiverse-Inventories, if relevant.

Checklist

  • I am running latest version of this resource.
  • I have read the wiki to make sure it's not an issue with configuration.
  • I ticked all of these boxes without actually reading them.
  • I have checked that my bug report is unique and a previous report does not exist.
@FemBoysAreCute
Copy link
Contributor Author

Ez Fix: add a config option to disable per gamemode inventory + add per world gamemode option

@RockinChaos
Copy link
Owner

Ez Fix: add a config option to disable per gamemode inventory + add per world gamemode option

The option to disable per gamemode inventory already exists, it's called Store-Inventory in the config.yml.

Though this isn't really a fix, that's just a workaround for the actual issue. I should have a fix soon that resolves this issue, I am currently working on some improvements to the database so I am working on finishing those before I push the commit to fix the inventory issue.

I'll look into adding the per world gamemode option as well.

@RockinChaos
Copy link
Owner

Okay so I did some testing and to be honest this is intended behavior. I tried to come up with a way for this to function with Multiverse-Inventories but there isn't really any as it's doing the intended behavior. The point is to restore your previous survival inventory when you exit creative and visa-versa when you enter creative.

My suggestion is to use the Store-Inventory option in the config.yml by setting it to false. It completely disables the inventory swapping allowing multiverse-inventories to handle the inventory properly. I updated the documentation for the next snapshot to this specific toggle as it should be set to false when using a multi-inventory plugin.

As for the per-world gamemode option I am currently working on this so I'll bump this issue to a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants