Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Empty state variations Logic #598

Merged
merged 11 commits into from
Dec 22, 2021
Merged

feat: Empty state variations Logic #598

merged 11 commits into from
Dec 22, 2021

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Dec 21, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

@ggazzo ggazzo marked this pull request as ready for review December 22, 2021 02:34
@ggazzo ggazzo merged commit 06ee58c into develop Dec 22, 2021
@ggazzo ggazzo deleted the feat/empty-states-error-variations branch December 22, 2021 02:34
This was referenced Sep 13, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @rique223