Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint): Add missing ESLint rule for TypeScript #470

Merged
merged 2 commits into from
Jun 16, 2021
Merged

fix(eslint): Add missing ESLint rule for TypeScript #470

merged 2 commits into from
Jun 16, 2021

Conversation

tassoevan
Copy link
Collaborator

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have labeled the PR correctly with the related package
  • I have run Loki's visual regression tests (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

It needs a special rule for TypeScript.

Issue(s)

Further comments

@tassoevan tassoevan requested a review from a team June 15, 2021 19:51
dougfabris
dougfabris previously approved these changes Jun 15, 2021
View reviewed changes
@dougfabris dougfabris dismissed their stale review June 15, 2021 20:49

ops, found lint issues

@ggazzo ggazzo merged commit cc0d498 into develop Jun 16, 2021
@ggazzo ggazzo deleted the fix/no-use-before-define-lint-rule branch June 16, 2021 01:24
gabriellsh added a commit that referenced this pull request Jun 23, 2021
@gabriellsh
Merge branch 'new/image-manipulation' of github.com:RocketChat/Rocket…
9daed46 
….Chat.Fuselage into new/image-manipulation

* 'new/image-manipulation' of github.com:RocketChat/Rocket.Chat.Fuselage:
  Update tsconfig.json
  chore: Update icon building readme (#472)
  fix: Menu component and options.label prop type (#476)
  fix: endReached prop in _Options of PaginatedSelectFiltered Component (#475)
  fix: Export MultiSelect component in .d.ts file (#473)
  feat(ui-kit): Attachment Surface (#474)
  fix(fuselage): Fuselage production build (#477)
  feat: onboarding-ui package (#463)
  fix(eslint): Add missing ESLint rule for TypeScript (#470)
  fix(string-helpers):  typesVersions (#469)
This was referenced Sep 13, 2023
Closed
Closed
Merged
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@dougfabris dougfabris dougfabris left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tassoevan @ggazzo @dougfabris