File Uploaded text on attachments to i18n Bugged

[Molle500]

This was suppose to be fixed for about 3 months ago #4058 .
However there is something bugged about this one becouse it's not reacting to the translation.

[geekgonecrazy]

@Molle500 is this a file uploaded prior to the translation? If so its not going to change. That text is stored on the message record.

[engelgabriel]

@geekgonecrazy if that is the case, we should create an issue to change that, and use the message rendered to translate the message on the UI and not in the backend.

[geekgonecrazy]

Yeah looks like we translate on creation of the attachment and store it:

https://github.com/RocketChat/Rocket.Chat/blob/develop/packages/rocketchat-file-upload/server/methods/sendFileMessage.js#L18

[Molle500]

@geekgonecrazy This is a new uploaded file so it's after the translation. You can change language to swedish and try for urself if u want :)

[MartinSchoeler]

@Molle500 @geekgonecrazy I think the problem with 'UNREAD MESSAGES' is that this text is being added on a css file, here:

Rocket.Chat/packages/rocketchat-theme/assets/stylesheets/base.less

Line 180 in 8fcfa3f

content: "unread messages";

not even using the i18n system

[geekgonecrazy]

@MartinSchoeler I completely missed that one. Yeah that one it does look like is in css

[engelgabriel]

@MartinSchoeler @Molle500 has this been fixed now?

[Molle500]

It might have been fixed, i saw there was a few lines at lingohub that wasn't translated with "File Uploaded". I will check after next lingo update :) @engelgabriel

[Molle500]

This one still do not work :/

[MartinSchoeler]

Hey @Molle500 i'm working on that issue and i wanted to know your opinion on what to do with the old file names, I can either create a migration to remove the "File Uploaded" string from files or leave them as is.
Thanks!

[geekgonecrazy]

I personally think we should have the fix take place from here forward. On large servers like say the demo server where we have a looooooooooot of file uploads. This could be a very heavy migration. So I think it would be better to just have all messages here on out be properly translated.

Just my two cents :)