Cannot modify custom emoji without re-uploading it

[paulchen]

Description:

When editing a custom emoji without uploading a new file, the error message "No file uploaded" appears when clicking the "Save" button and the changes will not be saved.

Steps to reproduce:

1. Add a custom emoji in case you don't already have one.
2. Select a custom emoji for editing.
3. Edit its name or aliases.
4. Click the "Save" button.

Expected behavior:

The changes are saved without an error.

Actual behavior:

An error message is shown and the changes will not be saved:

Server Setup Information:

• Version of Rocket.Chat Server: 5.1.4
• Operating System: Debian GNU/Linux
• Deployment Method: Docker
• Number of Running Instances: 1
• DB Replicaset Oplog: ?
• NodeJS Version: 14.19.3
• MongoDB Version: 5.0.12

Client Setup Information

• Desktop App or Browser Version: Chromium 106.0.5249.61 (Offizieller Build) Arch Linux (64-Bit), Firefox 105.0.1 (64-Bit)
• Operating System: Arch Linux

[florisvangeel]

rename-emoji.mp4

Confirmed this does not work in 5.1.4

[kartikbh6614]

firstly create an emojis you want ADD then edit to them with help of typescript then get to server and add to them emojis or single symbol list

[codewithmitesh]

Is anyone solving this issue? If not, @dudanogueira would you kindly assign this to me?

[Cob0ld]

I can't tell if it's related, but we can't update our custom emojis.... you can save the new emoji, but it always resets to the older image. this also happens if i delete the emoji and recreate it later.

[dudanogueira]

there is indeed something going off here. Let's try to make it into 6.1.0!

[Gardezi1]

Hey guys can i pick up this issue. Seems like nobody has started working on this issue

[XpertWebApp]

this issue is fixed now , please check

1.Rocket.Chat.mp4

[paulchen]

this issue is fixed now , please check

@XpertWebApp in which release? In 5.4.3 this problem still persists.

[AdityaSingh-02]

hey @XpertWebApp which version are you using, on my 6.0.0-develop i am still facing the issue

[Gardezi1]

I'll start looking into the issue. Because I'm also running into this issue. Can somebody please assign me this task

[XpertWebApp]

hey @XpertWebApp which version are you using, on my 6.0.0-develop i am still facing the issue

i am using node version 14.21.2 ,(npm v 6.14.17)

[florisvangeel]

This issue can be closed.

[paulchen]

This issue can be closed.

No, it can't. I just fired up the current develop image from Docker Hub locally. It identifies itself as 6.3.0-develop from Git revision 3d3bf4d832. This is on par with the current develop Git branch.

I'm afraid that this issue still occurs using that version:

simplescreenrecorder-2023-04-19_19.46.55.mp4

[mahmoodshariff123]

is this issue is open or closed? If it is open can you please assign it to me?