Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Web Browser: Emoji picker is not in viewport when opened (Iphone) #11128

Closed
kkovrizhenko opened this issue Jun 13, 2018 · 5 comments
Closed

Comments

@kkovrizhenko
Copy link

Description:

Steps to reproduce:

  1. Go to Rocket Chat using Mobile web browser (or simulator fo relevant screen size)
  2. Open any DM or chat room
  3. Click on Emoji icon in the input area

Expected behavior:

Emoji picker is opened

Actual behavior:

Emoji picker is not visible, hidden under left side of the screen
2018-06-13_1632

@ramrami
Copy link
Contributor

ramrami commented Jul 9, 2018

I have the same problem.
I think it's because of this condition in rocketchat-emoji/client/lib/EmojiPicker.js#setPosition:

		if (left + this.width >= window.innerWidth) {
			cssProperties.left = left - this.width - windowBorder;
		}

@zigfighter
Copy link

This problem is around quite a while appartenly and it is not only Iphone but all current Browsers on android mobiles as well.

@reetp
Copy link

reetp commented Oct 28, 2018

@zigfighter carried out some extensive testing on latest 0.70.4 and this is still present across browsers.

@ramrami
Copy link
Contributor

ramrami commented Oct 29, 2018

@zigfighter @reetp I just opened a fix for this problem #12457

@zigfighter
Copy link

@ramrami looking good ! needs to be reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants