Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jitsi] Mobile application ignores Enable room name hash server option #2505

Closed
ankar84 opened this issue Sep 29, 2020 · 7 comments · Fixed by #2905
Closed

[Jitsi] Mobile application ignores Enable room name hash server option #2505

ankar84 opened this issue Sep 29, 2020 · 7 comments · Fixed by #2905

Comments

@ankar84
Copy link
Contributor

ankar84 commented Sep 29, 2020

Description:

RocketChat/Rocket.Chat#17481 introduced new feature in Rocket Chat that enable simple Jitsi room names (not hashed abracadabra) but RC RN mobile app not support that and create room name in old fashion.
I think, that RC RN mobile app just ignores Enable room name hash option.
@diegolmello @djorkaeffalexandre please add support of that setting to RC RN mobile app, because if admin enable that feature (Turn Off Enable room name hash which is enabled by default to backward compatibility) Web version and Mobile version will create different rooms and users will not meet each other.

Environment Information:

  • Rocket.Chat Server Version: 3.6.3
  • Rocket.Chat App Version: 4.10
  • Device Name: iPhone 8
  • OS Version: iOS 14

Steps to reproduce:

  1. Admin UI and Turn Off Enable room name hash setting
  2. Create call in private group or DM in Web version
  3. Click on button Click to Join in Mobile version - you create another Jitsi room with old style name (hashed style starting with RC Deployment ID)

Expected behavior:

RC RN mobile app use same Jitsi room name as Web version with Enable room name hash turned off setting

Actual behavior:

Mobile application doesn't support Enable room name hash option

Additional context:

No.

@ankar84 ankar84 changed the title Mobile application ignores Enable room name hash server option [Jitsi] Mobile application ignores Enable room name hash server option Sep 29, 2020
@djorkaeffalexandre
Copy link
Collaborator

djorkaeffalexandre commented Sep 29, 2020

Thanks for your report @ankar84.
Let's do this when possible, if someone from community wants to pick this, is just to copy the exact logic of web client. :)
I've opened an issue that will help we with issues like this. RocketChat/Rocket.Chat#19056
Thanks.

@imrishabh18
Copy link
Contributor

imrishabh18 commented Sep 30, 2020

@djorkaeffalexandre I will take this 🙂. Will be really great if I can get some direction on resolving this issue as I am new to this codebase.

@clpacheco90
Copy link

I'm getting the same issue.
rocket chat version:3.7.1
app:4.11.0.2137

@cmdares
Copy link

cmdares commented Nov 7, 2020

I'm getting the same issue.

@ankar84
Copy link
Contributor Author

ankar84 commented Nov 25, 2020

@djorkaeffalexandre @imrishabh18 @diegolmello Hello, guys!
Can fix for that issue be included in 4.13 version?

@skug67
Copy link

skug67 commented Jan 4, 2021

Seems to still be a problem in 4.13. Definitely interferes w/making Rocket/Jitsi interoperable on mobile devices.

@ankar84
Copy link
Contributor Author

ankar84 commented Jan 10, 2021

@djorkaeffalexandre @diegolmello hey guys!
That issue looks like easy to fix but no one from community took it. So, please fix it by yourself.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants