macOS application from pkg crashes on launch because codesign

[MichalMMac]

macOS version of RocketChat 2.12.1 from dmg works fine.
However pkg installer installs app which crashes during lauch probably because of codesigning related problem. See attached crashlog.

Exception Type:        EXC_CRASH (Code Signature Invalid)
Exception Codes:       0x0000000000000000, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    Namespace CODESIGNING, Code 0x1

Rocket.Chat+_2018-08-20-153426_HungryHippo.crash.zip

[engelgabriel]

The last working version was before rocketchat-2.10.2.pkg

[engelgabriel]

The Develop is also broken

[engelgabriel]

Travis seems to be trying to upload the .pkg file twice

[tassoevan]

@engelgabriel

I didn't see the same error about unsigned pkg (probably because I was installing it via installer command in terminal), just the crash reported by @MichalMMac. It isn't the package file which is corrupted, but the Electron executable itself.

Also, the file name changed due to electron-builder fix for artifactName property (from rocketchat-${version} to Rocket.Chat-${version}. I saw this happening in Windows builds yesterday, I'm going to patch it.

[MichalMMac]

I see the crash again with 2.13.1.

[tassoevan]

@MichalMMac Are you installing rocketchat-2.13.1.pkg or rocketchat-2.13.1-mas.pkg?

[MichalMMac]

@tassoevan I am installing ocketchat-2.14.pkg. I looks it works OK. This issue can be probably closed.

[tjanson]

Just FYI: I upgraded to 2.17 (using the auto-updater, which prompted me) and it crashed with termination reason CODESIGNING. I did not keep a crash log or anything; I just downgraded to 2.16.2.

[tassoevan]

@tjanson What MacOS version are you running?

[tjanson]

@tassoevan latest Catalina: macOS 10.15.1 (19B88)